Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update actions #208

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Update actions #208

merged 2 commits into from
Jan 15, 2025

Conversation

yardasol
Copy link
Contributor

@yardasol yardasol commented Jan 15, 2025 •
edited
Loading

Summary of changes

This PR updates the versions of actions in SaltProc
It also fixes the maintainer email to a current one.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Required for Merging

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change is a source code change
    • I have added/modified tests to cover my changes
    • I have explained why my change does not require new/modified tests
  • My change is a user-facing change
    • I have recorded my changes in the changelog for the upcoming release
  • My change is exclusively related to the repository (e.g. GitHub actions workflows, PR/issue templates, etc.)
    • I have verified or justified that my change will work as intended.
  • All new and existing tests passed.
    • CI tests pass
    • Local tests pass (including Serpent2 integration tests)

Associated Issues and PRs

Checklist for Reviewers

Reviewers should use this link to get to the
Review Checklist before they begin their review.

@yardasol
update actions
6d5b69e 
- change to most recent version of actions
- remove mambaforge specifier for setup-miniconda (see [this](https://github.com/conda-forge/miniforge/tree/24.11.2-0) version of miniforge)
- bump python version to 3.10
@yardasol yardasol requested a review from samgdotson January 15, 2025 17:36
samgdotson
samgdotson approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@samgdotson samgdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samgdotson
Copy link
Contributor

Merging despite failing checks to enable PR #209.

@samgdotson samgdotson merged commit d90d275 into arfc:master Jan 15, 2025
1 check failed
github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
@samgdotson
update docs at commit: Merge pull request #208 from yardasol/update-a…
edf63fe 
…ctions

Update actions d90d275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samgdotson samgdotson samgdotson approved these changes

Assignees
No one assigned
Labels
Comp:Analysis Difficulty:1-Beginner Priority:2-Normal Status:5-In Review Type:Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yardasol @samgdotson