Merge pull request #62 from argentlabs/fix/reject-exception-connect

fix: manage promise reject when user reject a connection in connect m…
argentlabs · Jan 20, 2024 · 5927c00 · 5927c00
2 parents e447605 + f7a7c63
commit 5927c00
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/main.ts b/src/main.ts
@@ -125,7 +125,7 @@ export const connect = async ({
     return target
   }
 
-  return new Promise((resolve) => {
+  return new Promise((resolve, reject) => {
     const modal = new Modal({
       target: getTarget(),
       props: {
@@ -150,6 +150,8 @@ export const connect = async ({
                 connector,
               })
             }
+          } catch (error) {
+            reject(error)
           } finally {
             setTimeout(() => modal.$destroy())
           }

diff --git a/src/modal/Modal.svelte b/src/modal/Modal.svelte
@@ -1,6 +1,5 @@
 <script lang="ts">
   import type { StarknetWindowObject } from "get-starknet-core"
-  import sn from "get-starknet-core"
   import { onMount } from "svelte"
   import ConnectorButton from "./ConnectorButton.svelte"
   import type { ModalWallet } from "../types/modal"
@@ -29,8 +28,6 @@
     setLoadingItem(connector?.id ?? false)
     try {
       await callback(connector ?? null)
-    } catch (e) {
-      console.error(e)
     } finally {
       setLoadingItem(false)
     }