fix: update argent mobile rpc methods #104
Conversation
bluecco
requested review from
mluisbrown,
dhruvkelawala,
kamilargent and
vladutjs
|
@mluisbrown Plan is to update mobile-bridge PR once get-starknet has a stable release, i.e everything is merged on master branch. Currently it's on develop |
|
Checking further I think this might break Wallet Connect for mobile (at least iOS) as we are using the |
|
@mluisbrown let's keep this pr open until we are all on the same page |
| @@ -50,9 +50,9 @@ export class StarknetAdapter | |||
| // NamespaceAdapter | |||
| public namespace = "starknet" | |||
| public methods = [ | |||
There was a problem hiding this comment.
we need to be backwards compatible, so to the outside world we should expose wallet_* methods, but to the mobile client via WC starknet_* requests should be send
There was a problem hiding this comment.
FYI on the cloient side we will add support for wallet_ prefix as well, so that we can get rid of the starknet_ prefix at some point in the future cc: @mluisbrown
There was a problem hiding this comment.
@kamilargent just to be clear
atm we'll accept wallet_ and, in starknetkit, rename that to starknet_ for this current release?
There was a problem hiding this comment.
Yes, to the Dapp developer it should look like we use wallet_requestAddInvokeTransaction but internally to WC everything with starknet_ will be send. And it will have to be kept like that for a few months, until we get nice adoption of mobile apps.
There was a problem hiding this comment.
@kamilargent updated
| const requestToCall = this.handleRequest[call.type] | ||
| let type = call.type as string | ||
|
|
||
| if ( |
There was a problem hiding this comment.
minor: maybe worth adding a comment that we are adding it temporarily for backwards compatibility and mobile will add support for starknet_* calls that we can switch to in few months
No description provided.