Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dappName required for argent mobile connector #121

Merged
merged 2 commits into from
Aug 12, 2024
Merged

fix: dappName required for argent mobile connector #121

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93f6700
fix: dappName required for argent mobile connector
bluecco Aug 12, 2024
19c8c95
fix: url required for argent mobile connector
bluecco Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/connectors/argentMobile/index.ts
View file
Open in desktop
kamilargent marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import { isInArgentMobileAppBrowser } from "./helpers"
import { InjectedConnector, InjectedConnectorOptions } from "../injected"

export interface ArgentMobileConnectorOptions {
dappName?: string
dappName: string
projectId?: string
chainId?: constants.NetworkName
description?: string
Expand All @@ -46,7 +46,7 @@ export class ArgentMobileBaseConnector extends Connector {
private _wallet: StarknetWindowObject | null = null
private _options: ArgentMobileConnectorOptions

constructor(options: ArgentMobileConnectorOptions = {}) {
constructor(options: ArgentMobileConnectorOptions) {
super()
this._options = options
}
Expand Down