Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support keplr with latest @starknet-io/get-starknet-core version #142

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

bluecco
Copy link
Contributor

@bluecco bluecco commented Oct 17, 2024

Issue / feature description

Keplr wallet wasn't fully supported (discovery)

Changes

  • updated@starknet-io/get-starknet-core to support it

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

Please keep your pull request as small as possible. If you need to make multiple changes, please create separate pull requests for each change. Create a draft pull request if you need early feedback. This will mark the pull request as a work in progress and prevent it from being reviewed or merged until you are ready.

Please move drafts to the ready for review (regular PR) when you are ready to start the review process and other developers will pick it up from there.

@bluecco
Copy link
Contributor Author

bluecco commented Oct 17, 2024

image

image

@bluecco bluecco mentioned this pull request Oct 17, 2024
5 tasks
@bluecco bluecco merged commit 626ba0e into develop Oct 17, 2024
1 check passed
@bluecco bluecco deleted the fix/add-keplr-support branch October 17, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants