Skip to content

fixed error formatting when function fails #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmrich merged 1 commit into from
Mar 27, 2026
Merged

fixed error formatting when function fails #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions alcf/globus/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,9 @@ def get_task_status(user: account_models.User, task_id: str):
# Failed
if result["error"]:
status = task_models.TaskStatus.failed.value
result = result["error"]
result = {
"error": result["error"]
}

# Completed
else:
Expand All @@ -228,7 +230,9 @@ def get_task_status(user: account_models.User, task_id: str):
# Failed if an error occured outside of the function execution
else:
status = task_models.TaskStatus.failed.value
result = "?????"
result = {
"error": "Unexpected error outside of the function execution."
}

# Return the status and result (if any)
return status, result
Expand Down
2 changes: 2 additions & 0 deletions alcf/task/alcf_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,8 @@ async def _update_iri_task(self, user: account_models.User, iri_task: task_model
result_for_db = json.dumps(result)
else:
result_for_db = json.dumps(result.model_dump())
elif status == task_models.TaskStatus.failed.value:
result_for_db = json.dumps(result)
except Exception as e:
raise HTTPException(
status_code=HTTP_500_INTERNAL_SERVER_ERROR,
Expand Down
Loading