feat: add configurable cluster domain support #1872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuni-sa
force-pushed
the
feat/configurable-cluster-domain-1149
branch
from
f661422 to
0bb5720
Compare
Fixes argoproj-labs#1149 Signed-off-by: Yonatan Sasson <yonatanxd7@gmail.com>
Signed-off-by: Yonatan Sasson <yonatanxd7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
Removes the hardcoded cluster.local DNS suffix and makes it configurable so the operator works on clusters with custom DNS domains.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #1149
How to test changes / Special notes to the reviewer:
Change default cluster domain on a kubernetes cluster or change coredns settings to do a rewrite from a custom domain to cluster.local.