Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(applicationset): add the ability to exclude files when using the git file generator #13690 #15980

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hubmat00
Copy link

This PR implements the feature/enhancement for ApplicationSets to exclude specific files or files within specific directories when using the git file generator.

Closes #13690

The implementation is based on the already existing and proposed PR of @adamjohnson01 in the old repo. Thanks to @adamjohnson01

Note

The include/exclude (filtering) logic of this implementation includes backward-compatibility to already existing ApplicationSets.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@hubmat00 hubmat00 force-pushed the feat/add-git-file-exclude branch from fd4263a to d637488 Compare October 16, 2023 10:42
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f8f9ae9) 49.69% compared to head (f2b66f9) 49.57%.
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15980      +/-   ##
==========================================
- Coverage   49.69%   49.57%   -0.13%     
==========================================
  Files         267      269       +2     
  Lines       46362    46622     +260     
==========================================
+ Hits        23039    23111      +72     
- Misses      21063    21237     +174     
- Partials     2260     2274      +14     
Files Coverage Δ
.../apis/application/v1alpha1/applicationset_types.go 22.06% <ø> (ø)
applicationset/generators/git.go 84.45% <89.18%> (+0.09%) ⬆️

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…tor (argoproj#13690)

Signed-off-by: hubmat00 <54903550+hubmat00@users.noreply.github.com>
@hubmat00 hubmat00 force-pushed the feat/add-git-file-exclude branch from d637488 to f2b66f9 Compare October 20, 2023 21:40
@ruanyl
Copy link

ruanyl commented Jan 23, 2024

Any updates to this PR?

@ronit87
Copy link

ronit87 commented Feb 16, 2024

Is this PR planned in future release?

@zvlb
Copy link
Contributor

zvlb commented Jun 29, 2024

Any updates? Realy need this feature)

@michaelkorofiverr
Copy link

any updates on this? it can really simplify our applicationset declarations

@banschikovde
Copy link

When will this feature be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to exclude files when using the git file generator #468
6 participants