chore: enable more rules from go-critic by default

[mmorel-35]

Description

Enables and fixes more rules from go-critic

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.31%. Comparing base (8849c3f) to head (4d798bd).
⚠️ Report is 55 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/utils/kube/resource_ops.go	0.00%	4 Missing ⚠️
pkg/utils/text/text.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
- Coverage   54.26%   47.31%   -6.96%     
==========================================
  Files          64       64              
  Lines        6164     6529     +365     
==========================================
- Hits         3345     3089     -256     
- Misses       2549     3185     +636     
+ Partials      270      255      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ppapapetrou76]

The gitops-engine repository is migrating to https://github.com/argoproj/argo-cd.

The Golangci config file will be deleted, and we should use the parent file https://github.com/argoproj/argo-cd.

@mmorel-35 Is it ok to close this PR? we can open a new one after the migration is over

[mmorel-35]

That's fine fine for me. What is your strategy with the integration of the code in argo-cd and the compliance with golangci-lint ?
Correct me if I misunderstood, you want to merge it as it is then fix compliance ?