Skip to content

Commit

Permalink
Merge pull request #1500 from argos-ci/remove-build-status-filter
Browse files Browse the repository at this point in the history
fix: remove build status filter, until reviews are done
  • Loading branch information
gregberge authored Jan 2, 2025
2 parents fec3289 + fb06824 commit 1e7dc74
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 106 deletions.
96 changes: 0 additions & 96 deletions apps/frontend/src/pages/Project/BuildStatusFilter.tsx

This file was deleted.

12 changes: 2 additions & 10 deletions apps/frontend/src/pages/Project/Builds.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@ import { useProjectContext } from ".";
import { BuildStatsIndicator } from "../Build/BuildStatsIndicator";
import { NotFound } from "../NotFound";
import { BuildNameFilter, useBuildNameFilterState } from "./BuildNameFilter";
import {
BuildStatusFilter,
useBuildStatusFilterState,
} from "./BuildStatusFilter";
import { BuildTypeFilter, useBuildTypeFilterState } from "./BuildTypeFilter";
import { GettingStarted } from "./GettingStarted";

Expand Down Expand Up @@ -305,10 +301,8 @@ const PageContent = (props: { accountSlug: string; projectName: string }) => {
setSearchParams({});
};
const [buildName, setBuildName, isBuildNameDirty] = useBuildNameFilterState();
const [buildStatus, setBuildStatus, isBuildStatusDirty] =
useBuildStatusFilterState();
const [buildType, setBuildType, isBuildTypeDirty] = useBuildTypeFilterState();
const hasFilters = isBuildNameDirty || isBuildStatusDirty || isBuildTypeDirty;
const hasFilters = isBuildNameDirty || isBuildTypeDirty;
const projectResult = useSafeQuery(ProjectQuery, {
variables: {
accountSlug: props.accountSlug,
Expand All @@ -320,9 +314,8 @@ const PageContent = (props: { accountSlug: string; projectName: string }) => {
return {
name: buildName,
type: Array.from(buildType),
status: Array.from(buildStatus),
};
}, [buildName, buildType, buildStatus]);
}, [buildName, buildType]);

const buildsResult = useSafeQuery(ProjectBuildsQuery, {
variables: {
Expand Down Expand Up @@ -423,7 +416,6 @@ const PageContent = (props: { accountSlug: string; projectName: string }) => {
</PageHeaderContent>
<PageHeaderActions>
<BuildTypeFilter value={buildType} onChange={setBuildType} />
<BuildStatusFilter value={buildStatus} onChange={setBuildStatus} />
{project.buildNames.length > 1 && (
<BuildNameFilter
buildNames={project.buildNames}
Expand Down

0 comments on commit 1e7dc74

Please sign in to comment.