Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: avoid computing stats and conclusion #1495

Merged
merged 4 commits into from
Jan 1, 2025

Conversation

gregberge
Copy link
Member

No description provided.

@gregberge gregberge requested review from a team and jsfez and removed request for a team January 1, 2025 11:08
@gregberge gregberge force-pushed the refactor-stats-conclusion branch from e07ecec to e8b6691 Compare January 1, 2025 11:10
Copy link

argos-ci bot commented Jan 1, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 6 changed Jan 1, 2025, 4:55 PM

Client-side when the build is processing diff, we start to fetch them. It's a problem because the order is not yet stable. It results in a wrong UI at the end. To avoid that we don't display anything if all builds are not processed.
@gregberge gregberge force-pushed the refactor-stats-conclusion branch 2 times, most recently from 6a1b1c5 to 1313fa3 Compare January 1, 2025 16:47
@gregberge gregberge force-pushed the refactor-stats-conclusion branch from 1313fa3 to feab48e Compare January 1, 2025 16:54
@gregberge gregberge merged commit 115ad9f into main Jan 1, 2025
7 checks passed
@gregberge gregberge deleted the refactor-stats-conclusion branch January 1, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants