Fix ICE when emitting event with indexed function type requiring implicit conversion#16524
Open
chfast wants to merge 1 commit intoargotorg:developfrom
Open
Fix ICE when emitting event with indexed function type requiring implicit conversion#16524chfast wants to merge 1 commit intoargotorg:developfrom
chfast wants to merge 1 commit intoargotorg:developfrom
Conversation
…icit conversion The IR codegen asserted exact type equality between the argument and event parameter types for indexed function-type parameters. This fails when the argument has a different but implicitly convertible state mutability (e.g. pure -> view), since FunctionType::operator== compares mutability. Replace the strict equality check with individual structural assertions matching the legacy codegen: verify both types are external function types and the argument has no bound first argument. The underlying combineExternalFunctionIdFunction operates on raw (address, selector) stack values and is unaffected by mutability differences. Fixes argotorg#16298
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IR codegen asserted exact type equality between the argument and event parameter types for indexed function-type parameters (
IRVariable(arg).type() == *functionType). This fails when the argument has a different but implicitly convertible state mutability (e.g.function() external purepassed to an event expectingfunction() external view indexed), sinceFunctionType::operator==compares mutability.Replace the strict equality check with individual structural assertions matching the legacy codegen (
ExpressionCompiler.cpp:999-1009): verify both types are external function types and the argument has no bound first argument. The underlyingcombineExternalFunctionIdFunctionoperates on raw(address, selector)stack values and is unaffected by mutability differences.The legacy codegen is not affected — it already checks the argument and parameter types separately without requiring equality.
Fixes #16298