Escape feed titles and URLs in OPML export#14
Open
aphedges wants to merge 1 commit intoarguablykomodo:masterfrom
Open
Escape feed titles and URLs in OPML export#14aphedges wants to merge 1 commit intoarguablykomodo:masterfrom
aphedges wants to merge 1 commit intoarguablykomodo:masterfrom
Conversation
The export feature was failing to produce valid XML because it did not escape any characters when generating XML. Although most of the characters are uncommon in this situation, ampersands are common in URLs, which caused me to notice this problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The export feature was failing to produce valid XML because it did not escape any characters when generating XML. Although most of the characters are uncommon in this situation, ampersands are common in URLs, which caused me to notice this problem.
I found your extension a couple of months ago, and it's been very useful! I don't know if you still maintain it, but I have some more changes locally with bug fixes and minor improvements. If you are interested in reviewing and possibly merging them, then I can create some more PRs after this one.