Chunk proving pattern #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(chunk-pattern): changed circuits generation behavior
huitseeker
previously approved these changes
Feb 20, 2024
Cargo.toml
Outdated
Comment on lines
36
to
37
| [patch.crates-io] | ||
| pasta_curves = { git = "https://github.com/lurk-lab/pasta_curves", branch = "dev" } |
There was a problem hiding this comment.
This should no longer be necessary after argumentcomputer/arecibo#333
huitseeker
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
The goal of this PR is to create a bellpepper utility that could help us handle the
loop + accumulatorpattern in a circuit more efficiently.This implementation will be able to generate a number
Nof circuits based on the number of intermediate accumulator valuesNavand a desired number of accumulator updates per circuitNau(N=Nav/Nau).There is an example for a simple additive accumulator integrated in Supernova.
Usage
The current implementation only implements some chunking at the gadget level. This means that there is no actual generation of some folding steps, which would require a dependency on
areciboFrom
bellpepper-chunk, the user will have to implement the innerChunkStepCircuitthat will besynthesizeat each fold of ourRecursiveNova.Finally, the user will also have to develop the plumbing for
StepCircuitandNonUniformCircuitfromarecibo. Some of the methods implementation functions can be used through the use of the API ofFoldStepandInnerCircuit(see example).Open discussion
As you may know, there was some design discussions around adding
areciboas a dependency to abstract more of the implementation load from the user.For now we do not rely on
arecibobut it could be added quite easily if we wish to do so.