ci: Regenerate Plonk artifacts on push: dev
#189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelburnham
changed the title
push: devpush: dev
samuelburnham
force-pushed
the
ci-plonk-artifacts
branch
from
d631eaa
to
3e01493
Compare
samuelburnham
force-pushed
the
ci-plonk-artifacts
branch
2 times, most recently
from
3aace51
to
a807715
Compare
samuelburnham
force-pushed
the
ci-plonk-artifacts
branch
4 times, most recently
from
147dcd9
to
0bb05c3
Compare
samuelburnham
force-pushed
the
ci-plonk-artifacts
branch
from
0bb05c3
to
1e7f99f
Compare
huitseeker
reviewed
Oct 20, 2024
There was a problem hiding this comment.
This is great, but the trigger on every push to dev is a bit too much.
The source of truth for the circuit version is here:
Line 33 in 68a48fb
Would it make more sense to trigger the workflow either manually, or on every push that changed this value?
We can reasonably assume that in this case we would configure the repo to only squash-merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devworkflow_dispatchoption to release new artifacts with a custom name, e.g.v1.0.0-testnet.tar.gzSuccesful runs
Note
Artifact generation takes up to 30 minutes on a 32 vCPU Warpbuild runner. If performance is a concern, this could be reduced by 10-15 minutes with a more expensive AWS runner.