Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add from-one class to size and box-shadow demos #482

Merged
merged 2 commits into from
Mar 25, 2024
Merged

add from-one class to size and box-shadow demos #482

merged 2 commits into from
Mar 25, 2024

Conversation

Brian-Pob
Copy link
Contributor

Closes #481

@stackblitz StackBlitz
Copy link

stackblitz bot commented Mar 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@Crisfole
Copy link
Contributor

Do any of the “count-em” start from zero?

@Brian-Pob
Copy link
Contributor Author

Do any of the “count-em” start from zero?

The color swatches and inner-shadows start from 0.

And I just realized that the regular shadows start from 1.

@Brian-Pob Brian-Pob changed the title add from-one class to size demos add from-one class to size and box-shadow demos Mar 22, 2024
argyleink
argyleink approved these changes Mar 25, 2024
View reviewed changes
Copy link
Owner

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, this looks great!

@argyleink argyleink merged commit 59bb7e5 into argyleink:main Mar 25, 2024
2 checks passed
@Brian-Pob Brian-Pob deleted the sizes-fix branch April 8, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argyleink argyleink argyleink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sizes Counters Wrong
3 participants
@Brian-Pob @Crisfole @argyleink