-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Discord as social link #419
Conversation
I also have a pr in the works to convert the mastodon link into a generic activity pub link so people can put whatever platform supports the activity pub protocol in there, not just exclusively mastodon but it needs a bit more work Imo. I'll submit that later. |
@nathen418 I was thinking about how we can solve the issue with the link as the current implementation does not produce any valid link to the Discord profile. I was thinking like this: discord: {
displayName: 'john',
userId: 123123123,
}, Let me know what do you think? |
So what would the clickable link be? Or would this option omit one? The reason for how I structured the option to display an invite code and link to an invite was because there isn't a way to get a link to a discord user's profile unless you do something like If we don't need a link to a profile or something then I think doing discord: {
displayName: 'john',
userId: 123123123,
}, in |
We would have a link. I was thinking like this: https://discordapp.com/users/515878023111901184. If you visit the link, can you find my profile? |
Also, discord://-/users/603629606154666024 does not seem to do anything on my end. I am on windows machine and I don't have the discord app installed. |
Since I am not friends with you on Discord that link just redirects to https://discord.com/channels/@me so that won't work and I guess neither will my discord:// way apparently |
Ah bummer. Then we should find another approach. How about when the user clicks on the discord name, it copies the username only and we display a popup notification saying the username is copied? |
Yeah I like that idea. I can throw together an update to the pr in a few hours. |
Closing due to inactivity. |
This PR adds the option to include a Discord server link in the social links section.
Currently, the text that is displayed is the invite code as I didn't have a better idea of what to display for the link title. Feel free to suggest something else.
Partially resolves #380