Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Discord as social link #419

Closed
wants to merge 5 commits into from
Closed

Conversation

nathen418
Copy link
Contributor

This PR adds the option to include a Discord server link in the social links section.
Currently, the text that is displayed is the invite code as I didn't have a better idea of what to display for the link title. Feel free to suggest something else.

Partially resolves #380

@nathen418
Copy link
Contributor Author

nathen418 commented Jul 18, 2023

I also have a pr in the works to convert the mastodon link into a generic activity pub link so people can put whatever platform supports the activity pub protocol in there, not just exclusively mastodon but it needs a bit more work Imo. I'll submit that later.

@arifszn
Copy link
Owner

arifszn commented Jul 27, 2023

@nathen418 I was thinking about how we can solve the issue with the link as the current implementation does not produce any valid link to the Discord profile. I was thinking like this:

discord: {
  displayName: 'john',
  userId: 123123123,
},

Let me know what do you think?

@arifszn arifszn added this to the v3 milestone Jul 27, 2023
@nathen418
Copy link
Contributor Author

So what would the clickable link be? Or would this option omit one?

The reason for how I structured the option to display an invite code and link to an invite was because there isn't a way to get a link to a discord user's profile unless you do something like discord://-/users/603629606154666024 which only seems to work on mac and windows and only if you are friends with the user and the application is registered as a uri handler for the discord:// protocol. At the moment I handle this by doing this manually which is not ideal.

If we don't need a link to a profile or something then I think doing

discord: {
  displayName: 'john',
  userId: 123123123,
},

in gitprofile.config.js is a fine way to do things, I would just suggest changing displayName to userName as this is the user's actual semi-permanent username

@arifszn
Copy link
Owner

arifszn commented Jul 27, 2023

We would have a link. I was thinking like this: https://discordapp.com/users/515878023111901184. If you visit the link, can you find my profile?

@arifszn
Copy link
Owner

arifszn commented Jul 27, 2023

Also, discord://-/users/603629606154666024 does not seem to do anything on my end. I am on windows machine and I don't have the discord app installed.

@arifszn arifszn changed the base branch from main to v3 July 27, 2023 06:30
@nathen418
Copy link
Contributor Author

We would have a link. I was thinking like this: https://discordapp.com/users/515878023111901184. If you visit the link, can you find my profile?

Since I am not friends with you on Discord that link just redirects to https://discord.com/channels/@me so that won't work and I guess neither will my discord:// way apparently

@arifszn
Copy link
Owner

arifszn commented Jul 27, 2023

Ah bummer. Then we should find another approach. How about when the user clicks on the discord name, it copies the username only and we display a popup notification saying the username is copied?

@nathen418
Copy link
Contributor Author

Yeah I like that idea. I can throw together an update to the pr in a few hours.

@arifszn
Copy link
Owner

arifszn commented Jan 20, 2024

Closing due to inactivity.

@arifszn arifszn closed this Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding discord link
2 participants