Distro generalization #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zevweiss
changed the title
|
@zevweiss I like these changes, there's a minor nitpick found by the format check, with that fixed I'll be happy to merge, thanks! |
zevweiss
force-pushed
the
mount-enoent-nolog
branch
from
8bf91d2 to
103b617
Compare
Many of the paths virtme-ng-init tries to mount are distro-specific and may legitimately not exist; reduce the log noise by only logging mount failures for reasons other than ENOENT. Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
zevweiss
force-pushed
the
mount-enoent-nolog
branch
from
103b617 to
f42b2e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple small tweaks to be a bit more distro-agnostic...
Many of the paths virtme-ng-init tries to mount are distro-specific and may legitimately not exist; reduce the log noise by only logging mount failures for reasons other than ENOENT.
Don't try to run systemd-tmpfiles on non-systemd systems (not sure offhand if there's a better way of testing for systemd's presence than just looking for
/etc/systemd, but that's what I've done at the moment anyhow).