Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some refactorings in the hope this improves the code #2

Merged
merged 30 commits into from
Nov 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
7d49859
Use ? on Option where possible
psychon Nov 18, 2023
9c429bc
Add a simple test for extract_user_script()
psychon Nov 18, 2023
99b0992
Simplify extract_user_script()
psychon Nov 18, 2023
a1cf62f
Remove use of HashMap
psychon Nov 18, 2023
44b9d95
Remove Option return from run_misc_services()
psychon Nov 18, 2023
ffa33fb
Simplify an env var check
psychon Nov 18, 2023
125349d
Simplify(?) some environment lookup
psychon Nov 18, 2023
12759fe
Simplify lookup of $virtme_user
psychon Nov 18, 2023
f1f16aa
Simplify(?) some command construction
psychon Nov 18, 2023
1d1dc13
Remove useless Some-wrapping
psychon Nov 18, 2023
8a3c381
Remove unnecessary 'static
psychon Nov 18, 2023
1a67059
Replace e.g. libc::S_IRWXU with Mode::S_IRWXU
psychon Nov 18, 2023
ea2c534
Fix clippy warnings around logging
psychon Nov 18, 2023
a74c0e6
Fix clippy warnings about patterns
psychon Nov 18, 2023
d6e495b
Fix clippy warning about unnecessary return
psychon Nov 18, 2023
8e4452f
Fix clippy warnings about reading lines
psychon Nov 18, 2023
140f98b
Fix clippy warning about "loop never loops"
psychon Nov 18, 2023
ae7980f
Fix clippy warning about "push() after creation"
psychon Nov 18, 2023
e4fedd9
Fix clippy warning about unnecessary matching
psychon Nov 18, 2023
4447d7e
Simplify opening of TTYs
psychon Nov 18, 2023
0cc1ad3
Use uname() from nix instead of libc
psychon Nov 18, 2023
f072e04
Remove useless to_string()
psychon Nov 18, 2023
60740e7
Simplify /etc/shadow generation
psychon Nov 18, 2023
55dac47
Use utils::create_file() to write some file contents
psychon Nov 18, 2023
992e5f8
Remove an unnecessary Vec
psychon Nov 18, 2023
457bc57
Refactor logic in find_udevd()
psychon Nov 18, 2023
6f25e56
Allow run_cmd() with non-utf8-strings
psychon Nov 18, 2023
85a942e
Avoid allocations for static strings for run_shell()
psychon Nov 18, 2023
8cca65e
Use nix' flags instead of libc's in one more place
psychon Nov 18, 2023
6c5e94d
Avoid temporary allocation for PathBuf
psychon Nov 18, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading