Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly quoting exec string to avoid breaking virtme-run invocation … #222

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

andreasgrapentin
Copy link
Contributor

as requested, this PR fixes #221 by replacing the double quotes in the command string passed through --exec with a call to shlex.quote

Copy link
Owner

@arighi arighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@arighi arighi merged commit aa57790 into arighi:main Jan 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

command passed through --exec to --script-sh needs escaping
2 participants