Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtme-ng: Don't fail on missing argcomplete #33

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

zevweiss
Copy link
Contributor

The argcomplete dependency isn't critical, so let's continue on in its absence instead of blowing up (convenient for running the 'vng' command directly from the source tree without having to install any python module dependencies).

The argcomplete dependency isn't critical, so let's continue on in its
absence instead of blowing up (convenient for running the 'vng'
command directly from the source tree without having to install any
python module dependencies).

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
@zevweiss zevweiss force-pushed the argcomplete-optional branch from 4c48233 to 40475b4 Compare November 16, 2023 22:06
@arighi arighi merged commit 8524f79 into arighi:main Nov 17, 2023
3 checks passed
@arighi
Copy link
Owner

arighi commented Nov 17, 2023

Applied, thanks!

@zevweiss zevweiss deleted the argcomplete-optional branch November 17, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants