Moves from Signature V2 to Signature V4 for S3 #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the `Region` datatype, as found in DynamoDb to S3, and adds all regions as of today with a similar naming scheme, as used in DynamoDb. This change lays the basis for Signature V4 signing; it *does* break backwards compatibility!
Changes the signature method to version 4 to support the buckets in China (Beijing) or EU (Frankfurt). Fixes aristidb#167
This reverts commit cbdb8d4.
credentialV4 is useful outside of authorizationV4 as well. It is used to build the signed S3 URI link, whe the credentialV4 string is embedded in the canonical request.
|
|
|
Looks like I broke the google storage nearline example. |
|
This might eventually break google storage support? I'm not certain about that, and I don't have a gcs account nor did I find detailed documentation on the S3 compatibility. |
|
To keep compatibility with Google, maybe put a SignatureVersion field into the S3Config? Then the google config can just say "V2 signing please". |
|
And do I understand it correctly that you consider your pull request complete and ready for merging when you have ticked off all the checkboxes, @angerman ? |
|
I guess that would be optimal. Though I must admit, I don't see this getting finished soon. Especially multi-part seems to be quite tricky to get right. |
Closed
|
Superseded by #241 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR so far adds support for:
S3.GetBucket(not yet tested)S3.GetBucketLocation(not yet tested)S3.PutBucket(not yet tested)S3.DeleteBucket(not yet tested)S3.GetService(not yet tested)S3.HeadObject(not yet tested)S3.GetObject(REST)S3.GetObject(URL)S3.PutObject(without Content Sha256 by default)S3.Multipart(not yet tested)S3.CopyObject(not yet tested)S3.DeleteObject(not yet tested)S3.DeleteObjects(not yet tested)It additionally does:
authorizationV4authorizationV4signatureV4) and Credential (credentialV4) generation from theauthorizationV4as these were needed separately to support the URL generation forGetObject.It also introduces a breaking API change, as
Endpointsare replaced byRegions. I tried to keep these as similar to those provided inDynamoDb.It should fix #167