Merge pull request #70 from dolik-rce/optimize-table-resizing

Avoid resizing empty capture and value tables
arithy · Oct 22, 2023 · 80b9485 · 80b9485
2 parents b128a77 + 118254f
commit 80b9485
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/src/packcc.c b/src/packcc.c
@@ -4716,17 +4716,19 @@ static bool_t generate(context_t *ctx) {
                     "    ctx->level++;\n",
                     ctx->rules.buf[i]->data.rule.name
                 );
-                stream__printf(
-                    &sstream,
-                    "    pcc_value_table__resize(ctx->auxil, &chunk->values, " FMT_LU ");\n",
-                    (ulong_t)ctx->rules.buf[i]->data.rule.vars.len
-                );
-                stream__printf(
-                    &sstream,
-                    "    pcc_capture_table__resize(ctx->auxil, &chunk->capts, " FMT_LU ");\n",
-                    (ulong_t)ctx->rules.buf[i]->data.rule.capts.len
-                );
+                if (ctx->rules.buf[i]->data.rule.capts.len > 0) {
+                    stream__printf(
+                        &sstream,
+                        "    pcc_capture_table__resize(ctx->auxil, &chunk->capts, " FMT_LU ");\n",
+                        (ulong_t)ctx->rules.buf[i]->data.rule.capts.len
+                    );
+                }
                 if (ctx->rules.buf[i]->data.rule.vars.len > 0) {
+                    stream__printf(
+                        &sstream,
+                        "    pcc_value_table__resize(ctx->auxil, &chunk->values, " FMT_LU ");\n",
+                        (ulong_t)ctx->rules.buf[i]->data.rule.vars.len
+                    );
                     stream__puts(
                         &sstream,
                         "    pcc_value_table__clear(ctx->auxil, &chunk->values);\n"