error from Uplink::transmit when kble_gs is not connected to the satellite #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnected to the satellite
shunsuke-shimomura
changed the title
|
よい変更だと思う、んですが今レビューの時間取れないのであとで見ます |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
tmtc-c2a::kble_gs::Uplinkでtransmiする際、kble_gsが衛星につながっていないときエラーとして帰ってきていなかった。
kble_gs内のcmd_tx, cmd_rxに、Vecに加えてoneshot::Sender<Result<()>>を追加することで衛星との接続をエラーとして返すようにした。
発端となる Issue
#255 に問題点を記述