-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
新コマンド画面(opslang) #54
新コマンド画面(opslang) #54
Conversation
82fe086
to
20510e8
Compare
6792f98
to
b5baa23
Compare
22f963c
to
66892ed
Compare
未実装のもの
|
03e360e
to
95f2d7b
Compare
bd960a7
to
036e867
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
CIも通ったしそろそろマージしたい |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
特にインタプリタ部分をみました
正規表現で頑張ってるところはのちのちopslang側でちゃんと拾うということで
Cargo.toml
Outdated
exclude = [ | ||
"target", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これ Cargo 自身が管理しているディレクトリなので必要無いと思うのだけど,何かあったのかな
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OUT_DIR/devtools_frontend/crates/wasm-opslang に cd して wasm-pack build するようになってしまっているからですね
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あー,wasm を OUT_DIR
にコピってからビルドしてるのか(フロントエンドと一緒に)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
やや非自明なのでコメントあるとよさそう
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あと,tmtc-c2a/devtools_frontend/crates/
もですね
bff5c4f
to
fbc5aa0
Compare
既存のCommand画面(/devtools/command)に加えて、新たにCommand(Experimental Opslang)画面(/devtools/command_new)を追加
テスト用コマンド