Updated Kotlin to 2.0.0, Essenty to 2.1.0, Reaktive to 2.2.0, AGP to 8.2.0 #139
Conversation
WalkthroughThe recent updates encompass a variety of improvements and version upgrades across multiple files. Key changes include updates to dependency versions, enhancements to the build configuration, removal of outdated workarounds, and cleanup of internal classes. These modifications aim to improve compatibility, streamline the build process, and ensure the project leverages the latest features and bug fixes. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
gradle/wrapper/gradle-wrapper.jaris excluded by!**/*.jarkotlin-js-store/yarn.lockis excluded by!**/*.lock
Files selected for processing (14)
- .gitignore (1 hunks)
- build.gradle.kts (2 hunks)
- deps.versions.toml (2 hunks)
- gradle.properties (1 hunks)
- gradle/wrapper/gradle-wrapper.properties (1 hunks)
- gradlew (3 hunks)
- gradlew.bat (1 hunks)
- mvikotlin-timetravel-client/app-desktop/build.gradle.kts (1 hunks)
- mvikotlin-timetravel-client/extension-chrome/build.gradle.kts (1 hunks)
- mvikotlin-timetravel-proto-internal/src/nativeMain/kotlin/com/arkivanov/mvikotlin/timetravel/proto/internal/io/ReaderThread.kt (1 hunks)
- mvikotlin/api/android/mvikotlin.api (2 hunks)
- mvikotlin/api/jvm/mvikotlin.api (2 hunks)
- mvikotlin/src/commonMain/kotlin/com/arkivanov/mvikotlin/core/utils/LockExt.kt (1 hunks)
- settings.gradle.kts (1 hunks)
Files skipped from review due to trivial changes (10)
- .gitignore
- gradle.properties
- gradle/wrapper/gradle-wrapper.properties
- gradlew
- gradlew.bat
- mvikotlin-timetravel-client/app-desktop/build.gradle.kts
- mvikotlin-timetravel-proto-internal/src/nativeMain/kotlin/com/arkivanov/mvikotlin/timetravel/proto/internal/io/ReaderThread.kt
- mvikotlin/api/android/mvikotlin.api
- mvikotlin/api/jvm/mvikotlin.api
- mvikotlin/src/commonMain/kotlin/com/arkivanov/mvikotlin/core/utils/LockExt.kt
Additional comments not posted (5)
mvikotlin-timetravel-client/extension-chrome/build.gradle.kts (1)
8-8: Addition of the Kotlin Compose plugin aligns with the project's move towards using Jetpack Compose for UI components.settings.gradle.kts (1)
18-18: Updatedgradle-setup-pluginversion to ensure compatibility with the latest tools and practices.build.gradle.kts (2)
24-24: Addition of classpaths for new plugins ensures compatibility with updated versions.
82-82: Addition ofmavenLocal()to repositories. Ensure this is intended for production use and not just for local development.Consider removing
mavenLocal()if it's not necessary for production to avoid potential issues with dependency resolution.deps.versions.toml (1)
7-17: Updated dependency versions align with the project's goal to stay current with the latest stable releases.
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
gradle/wrapper/gradle-wrapper.jaris excluded by!**/*.jarkotlin-js-store/yarn.lockis excluded by!**/*.lock
Files selected for processing (14)
- .gitignore (1 hunks)
- build.gradle.kts (2 hunks)
- deps.versions.toml (2 hunks)
- gradle.properties (1 hunks)
- gradle/wrapper/gradle-wrapper.properties (1 hunks)
- gradlew (3 hunks)
- gradlew.bat (1 hunks)
- mvikotlin-timetravel-client/app-desktop/build.gradle.kts (1 hunks)
- mvikotlin-timetravel-client/extension-chrome/build.gradle.kts (1 hunks)
- mvikotlin-timetravel-proto-internal/src/nativeMain/kotlin/com/arkivanov/mvikotlin/timetravel/proto/internal/io/ReaderThread.kt (1 hunks)
- mvikotlin/api/android/mvikotlin.api (2 hunks)
- mvikotlin/api/jvm/mvikotlin.api (2 hunks)
- mvikotlin/src/commonMain/kotlin/com/arkivanov/mvikotlin/core/utils/LockExt.kt (1 hunks)
- settings.gradle.kts (1 hunks)
Files skipped from review as they are similar to previous changes (13)
- .gitignore
- build.gradle.kts
- gradle.properties
- gradle/wrapper/gradle-wrapper.properties
- gradlew
- gradlew.bat
- mvikotlin-timetravel-client/app-desktop/build.gradle.kts
- mvikotlin-timetravel-client/extension-chrome/build.gradle.kts
- mvikotlin-timetravel-proto-internal/src/nativeMain/kotlin/com/arkivanov/mvikotlin/timetravel/proto/internal/io/ReaderThread.kt
- mvikotlin/api/android/mvikotlin.api
- mvikotlin/api/jvm/mvikotlin.api
- mvikotlin/src/commonMain/kotlin/com/arkivanov/mvikotlin/core/utils/LockExt.kt
- settings.gradle.kts
Additional comments not posted (1)
deps.versions.toml (1)
7-17: Updated dependency versions align with PR objectives.Ensure that all modules using these dependencies are compatible with the new versions to avoid runtime issues.
| @@ -52,6 +52,7 @@ reaktive-coroutinesInterop = { group = "com.badoo.reaktive", name = "coroutines- | |||
| russhwolf-multiplatformSettings = { group = "com.russhwolf", name = "multiplatform-settings", version.ref = "multiplatformSettings" } | |||
|
|
|||
| compose-composeGradlePlug = { group = "org.jetbrains.compose", name = "compose-gradle-plugin", version.ref = "compose" } | |||
| kotlin-composeCompilerGradlePlug = { group = "org.jetbrains.kotlin", name = "compose-compiler-gradle-plugin", version.ref = "kotlin" } | |||
There was a problem hiding this comment.
Tip
Codebase Verification
The old plugin name compose-composeGradlePlug still exists in the deps.versions.toml file and needs to be updated to kotlin-composeCompilerGradlePlug.
- Location:
deps.versions.toml
Analysis chain
Renaming compose-composeGradlePlug to kotlin-composeCompilerGradlePlug is consistent with the summary.
Verify that all references to the old name are updated across the project.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that all references to the old plugin name are updated.
# Test: Search for the old plugin name. Expect: No occurrences.
rg --type toml 'compose-composeGradlePlug'
Length of output: 182
Script:
#!/bin/bash
# Description: Verify that all references to the old plugin name are updated.
# Test: Search for the old plugin name across the entire codebase. Expect: No occurrences.
rg 'compose-composeGradlePlug'
Length of output: 170
Summary by CodeRabbit
New Features
Bug Fixes
webpackCliversion setting.Chores
.gitignoreto exclude.kotlindirectory.Refactor