Implemented things by branch name, also: #14
Conversation
1) Created setContentDescription modifier that allows to set contentDescription on any used Modifier - as accessibility feature, suppossing that it may help to understand the UI architecture more
|
To understand how it looks like, attach few screenshots: when user mark more than max of the mines: |
|
@arkivanov Hello, please, check how it looks like! |
composeApp/src/commonMain/kotlin/com/arkivanov/minesweeper/game/GameState.kt
Outdated
Show resolved
Hide resolved
composeApp/src/commonMain/kotlin/com/arkivanov/minesweeper/ComposeUtils.kt
Outdated
Show resolved
Hide resolved
composeApp/src/commonMain/kotlin/com/arkivanov/minesweeper/game/GameContent.kt
Outdated
Show resolved
Hide resolved
composeApp/src/commonMain/kotlin/com/arkivanov/minesweeper/game/GameContent.kt
Outdated
Show resolved
Hide resolved
composeApp/src/commonMain/kotlin/com/arkivanov/minesweeper/game/GameContent.kt
Outdated
Show resolved
Hide resolved
composeApp/src/commonMain/kotlin/com/arkivanov/minesweeper/ComposeUtils.kt
Outdated
Show resolved
Hide resolved
1) decrease size of setSemantics, also rename in from setContentDescription 2) deprecate RemainingMines, create Counter, toCounterString 3) changes TODO idea
|
@arkivanov Hello, I'm made recommended changes, please, check how it looks like! |
composeApp/src/commonMain/kotlin/com/arkivanov/minesweeper/game/GameContent.kt
Outdated
Show resolved
Hide resolved
composeApp/src/commonMain/kotlin/com/arkivanov/minesweeper/game/GameContent.kt
Outdated
Show resolved
Hide resolved
2) Create TODO
|
Let's rock it! |
|
Thank you! |
Thank you too, for reviewing my code and making it better together! Hope I will start implementing the stopwatch soon, I don't want to use additional dependencies (for educational purposes for me and project, if someone wants to research it) Also I tried to go to wasm site from this repo, I also got amazed that you create a pipeline that automatically creates a build and publishes it to the site (you did a great work with this CI/CD) I visit it from mobile android chrome browser, and can't click anything. is this wasm restriction for now? Or it just doesn't work because in the project clicks are used instead of touches? |
|
Yeah, Wasm on Android chrome is pretty much broken currently. Also on any browser, all mouse clicks are recognised as left clicks. |
Not tested how it would work for mines >999, or <-99, things that code logic is draw more digits, how much it needs