For review: fix issue 53 by fiddling with assignability check #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersed for validation purposes
…he final instructions in a method
…ome places that would violate correctness
…direct (inferencing needs a lot of work there).
… separate build for netstandard 1.4 (only code difference is compiled regex); make dependencies less specific (was required previously to yank pre-release bits)
…of(object).IsAssignableFrom(typeof(void)) == true
…an assign a (boxed) struct to an interface. This fixes kevin-montrose#53
arlm
force-pushed
the
master
branch
2 times, most recently
from
e57a954
to
51b5efb
Compare
arlm
added a commit
that referenced
this pull request
Jul 10, 2019
arlm
added a commit
that referenced
this pull request
Jul 10, 2019
Closes PR #2 Co-authored-by: chaplin89 <chaplin89@gmail.com>
|
Is implemented on PR #8 |
arlm
added a commit
that referenced
this pull request
Jul 10, 2019
Closes PR #2 Co-authored-by: chaplin89 <chaplin89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes kevin-montrose#53. The IsAssignableFrom method wasn't accounting for the fact that you can assign a (boxed) struct to an interface.
I'm not very familiar with the codebase, so I don't know if this is the most effective way of fixing the bug, although the tests do all pass. Have a look at my code, feedback very welcome 😉