Add support for custom job service names #4181
Open
+476
−209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
…tom names Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Sovietaced
changed the title
d80tb7
reviewed
Feb 9, 2025
| @@ -4,6 +4,8 @@ import ( | |||
| "math" | |||
| "testing" | |||
|
|
|||
| "github.com/armadaproject/armada/internal/server/configuration" | |||
There was a problem hiding this comment.
this needs to be in the block with the armada imports at the bottom (annoyingly linting isn't intellligent enough to fix/catch this)
d80tb7
reviewed
Feb 9, 2025
| @@ -41,6 +41,7 @@ message IngressConfig { | |||
| message ServiceConfig { | |||
| ServiceType type = 1; | |||
| repeated uint32 ports = 2; | |||
| string name = 3; | |||
There was a problem hiding this comment.
lets put a comment saying what this does and what the behaviour is if you don't set it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4171
This pull request adds a fix for #4171 and includes a feature flag to enable the new features (defaults to false). It includes an update to the
ServiceConfigmessage that allows for an optional service name to be configured.As the PR currently sits, service name conflicts result in a recoverable error from the executor. I'm happy to change this but the error is plumbed to the user so I feel the user experience is ok and theoretically this could be a recoverable situation.