[WIP] Improve configurability of ingress config #4188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Signed-off-by: Jason Parraga <sovietaced@gmail.com>
Sovietaced
force-pushed
the
issue-4187
branch
from
5131225 to
0c44848
Compare
|
This pull requests needs more work. In order to get our setup to work we have to change even more of the code in |
Sovietaced
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4187
This pull request improves the configurability of the ingress config for environments like ours where we run nginx ingress, cert-manager, and external DNS. This change allows ingress classes to be configured and also gives the user more control over TLS hosts so that TLS hosts can be matched up with a DNS entry configured via the annotations. This allows for TLS termination of domain name targeted traffic.