Remove all non-resourcelist gogo annotations from schedulerobjects #4189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ma/scxhedulerobjects-internal
…ma/scxhedulerobjects-internal
…ma/remove-gogo-schedulerobjects
d80tb7
changed the title
robertdavidsmith
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all gogo annotations from schedulerobjects except for the non-null annotation on the three resourcelists. These can be removed when we get rid of the resourcelist. After that we can remove gogoproto as a dependency!
This also adds the deepcopys requests by @robertdavidsmith when converting between internaltypes.JobSchedulingInfo and schedulerobjects.JobSchedulingInfo.