fix: resolve OS image list duplication when switching filters#110
Merged
fix: resolve OS image list duplication when switching filters#110
Conversation
Use unique `file_url` as React list key instead of the composite `armbian_version-distro_release-kernel_branch` which was not unique across image variants, causing orphaned DOM nodes on each filter switch. Also reset the active filter back to "All Images" when the modal closes so re-opening always starts from the full list. Fixes #108
SuperKali
added
enhancement
🧪 Test BuildsVersion:
ℹ️ About these builds
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The React list key used a composite of
armbian_version-distro_release-kernel_branch, which is not unique across image variants. For example, on the Radxa Dragon Q6A board:25.11.1-noble-edge26.2.1-trixie-edgeDuplicate React keys cause the reconciliation algorithm to skip DOM deletion of overwritten fibers, leaving orphaned nodes that accumulate on each filter switch.
Changes
src/components/modals/ImageModal.tsximage.file_url, which is guaranteed unique per imageuseEffectthat resetsfilterTypeto'all'when the modal closesTest plan
Fixes #108