Handle a specific case of anyOf #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `anyOf` handling was not considering a case that's already coded in the kubenix generator, the int-or-string case. For reasons beyond my current knowledge, the CRDs I'm using (Cloudnative-PG) contain a property called `x-kubernetes-int-or-string` and not the expected `int-or-string` in the `format` property inside the `type`. This commit handles this case by patching up the definition so that the generator uses `either int str` instead of blindly picking the first one.
arnarg
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
anyOfhandling was not considering a case that's already coded in the kubenix generator, the int-or-string case.For reasons beyond my current knowledge, the CRDs I'm using (Cloudnative-PG) contain a property called
x-kubernetes-int-or-stringand not the expectedint-or-stringin theformatproperty inside thetype.This PR handles this case by patching up the definition so that the generator uses
either int strinstead of blindly picking the first one.