Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for the C# implementation #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Various fixes for the C# implementation #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6277bd2
cs: Extract Production code in a separate class
dmerejkowsky Feb 15, 2023
f7564c0
cs: add .gitignore, remove generated file from tracked files
dmerejkowsky Feb 15, 2023
cf0c41f
Replace FluentAssertions with Shouldly
dmerejkowsky Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions csharp/CurrencyConverter/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
.vs/
bin/
obj/

CurrencyConverter.Tests/Features/Calculator.feature.cs

TestResults/
11 changes: 11 additions & 0 deletions csharp/CurrencyConverter/CurrencyConverter.Tests/Calculator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
namespace CurrencyConverter.Tests
{
public class Calculator
{
public static int Add(int x, int y)
{
return x + y;
}
}

}
2 changes: 1 addition & 1 deletion csharp/CurrencyConverter/CurrencyConverter.Tests/CurrencyConverter.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.0.0" />
<PackageReference Include="Shouldly" Version="4.1.0" />
<PackageReference Include="SpecFlow.Plus.LivingDocPlugin" Version="3.9.57" />
<PackageReference Include="SpecRun.SpecFlow" Version="3.9.7" />
<PackageReference Include="FluentAssertions" Version="6.2.0" />
</ItemGroup>

</Project>
127 changes: 0 additions & 127 deletions csharp/CurrencyConverter/CurrencyConverter.Tests/Features/Calculator.feature.cs
View file
Open in desktop

This file was deleted.

9 changes: 6 additions & 3 deletions csharp/CurrencyConverter/CurrencyConverter.Tests/Steps/CalculatorStepDefinitions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using FluentAssertions;
using Shouldly;
using TechTalk.SpecFlow;

namespace CurrencyConverter.Tests.Steps
Expand Down Expand Up @@ -33,14 +33,17 @@ public void WhenTheTwoNumbersAreAdded()
{
var first = _scenarioContext.Get<int>("first");
var second = _scenarioContext.Get<int>("second");
_scenarioContext.Add("result", first + second);

var sum = Calculator.Add(first, second);

_scenarioContext.Add("result", sum);
}

[Then("the result should be (.*)")]
public void ThenTheResultShouldBe(int result)
{
var actualResult = _scenarioContext.Get<int>("result");
actualResult.Should().Equals(result);
actualResult.ShouldBe(result);
}
}
}