MINIFICPP-797: Add test and fix linter error#1
Open
phrocker wants to merge 2 commits intoarpadboda:MINIFICPP-797from
Open
MINIFICPP-797: Add test and fix linter error#1phrocker wants to merge 2 commits intoarpadboda:MINIFICPP-797from
phrocker wants to merge 2 commits intoarpadboda:MINIFICPP-797from
Conversation
arpadboda
force-pushed
the
MINIFICPP-797
branch
from
c7dbb1f to
8aa3c9a
Compare
arpadboda
pushed a commit
that referenced
this pull request
May 6, 2020
This closes apache#754 Remaining: - MSVC: multiple warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library - MSVC/expression language: multiple warning C4566: character represented by universal-character-name '\u????' cannot be represented in the current code page (1252) - clang/expression language yacc: warning: fix-its can be applied. Rerun with option '--update'. [-Wother] Squashed commit of the following: commit 9c55503 Author: Marton Szasz <szaszm01@gmail.com> Date: Wed Apr 15 18:30:10 2020 +0200 MINIFICPP-1151 revert ListSFTP as its issue is already fixed on master commit bacdadb Author: Marton Szasz <szaszm01@gmail.com> Date: Wed Apr 15 15:46:29 2020 +0200 MINIFICPP-1151 fix invalid fread usage commit 1b5ef64 Author: Marton Szasz <szaszm01@gmail.com> Date: Tue Apr 14 15:00:54 2020 +0200 MINIFICPP-1151 windows (except expression language) commit 96bfa5f Author: Marton Szasz <szaszm01@gmail.com> Date: Tue Apr 7 10:18:26 2020 +0200 MINIFICPP-1151 linux, clang 10 note: rocksdb compilation correctly fails with clang 10. We will need to upgrade or patch it. commit aff6571 Author: Marton Szasz <szaszm01@gmail.com> Date: Mon Feb 10 21:35:29 2020 +0100 verified on clang6/linux There are some warnings due to overriding a ROCKSDB_ASSERT macro to throw and it's expanded inside `noexcept` functions. No idea how to fix that. commit 265e3a7 Author: Marton Szasz <szaszm01@gmail.com> Date: Mon Feb 10 18:05:55 2020 +0100 fix compilation errors commit 5dcf968 Author: Marton Szasz <szaszm01@gmail.com> Date: Mon Feb 10 15:58:05 2020 +0100 MINIFICPP-1151 round #1: GCC 7 on ubuntu, default config MINIFICPP-1151 fix ProcessGroup lifetime by making it temporary Signed-off-by: Arpad Boda <aboda@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.