β‘ Fix memory leak in ShapeArray.Remove #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShapeArray(and effectivelyStruct).ShapeArray.Removewould swap the element to remove with the tail element (or shift the window), but left the reference to the "removed" object in the underlying array's tail. This prevented the object from being garbage collected until the array itself was reallocated or collected.BenchmarkSpacePartitionAddDelete(which involves heavy add/remove).Structpersists and shapes are removed, preventing gradual heap growth. The short-lived benchmark doesn't capture this long-term retention.TestShapeArray_Remove_MemoryLeakwhich explicitly checks that the underlying array element is set tonilafter removal, confirming the fix.PR created automatically by Jules for task 13652935647002778501 started by @arran4