added libraries to library path for gha, symlinked glibtool to libtool #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Duncan Ragsdale <88173870+Thistleman@users.noreply.github.com>
dchassin
approved these changes
Jan 23, 2024
dchassin
pushed a commit
that referenced
this pull request
Jan 27, 2024
#160) Signed-off-by: Duncan Ragsdale <88173870+Thistleman@users.noreply.github.com> Signed-off-by: David P. Chassin <david.chassin@me.com>
dchassin
pushed a commit
that referenced
this pull request
Jan 27, 2024
#160) Signed-off-by: Duncan Ragsdale <88173870+Thistleman@users.noreply.github.com> Signed-off-by: David P. Chassin <david.chassin@me.com>
dchassin
pushed a commit
that referenced
this pull request
Jan 27, 2024
#160) Signed-off-by: Duncan Ragsdale <88173870+Thistleman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the failing CI/CD builds for macos images.
Github runners using MACOS were unable to locate libraries that were tested and confirmed to be in their /usr/local directories. Additionally, macos 13 was unable to locate libtool, which is due to glibtool being installed.
Symlinked glibtool to libtool to resolve the naming issue.
Added LIBRARY_PATH to the github environment, and added the /usr/local/(lib/opt/include) directories to the path. This allows the runner's compiler to now find the needed libraries.