Fix integration test retry timing for eventual consistency#14
Merged
Conversation
The _eventually_fetch helper defaulted to 3s timeout / 0.25s interval, which wasn't enough for the Kalshi query-exchange service to index newly placed orders. Bumped to 30s / 5s to handle API propagation delay. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_eventually_fetchdefault timeout from 3s to 30s and interval from 0.25s to 5s intests/integration/test_portfolio.pytest_get_order_by_idwhich was failing because the Kalshi query-exchange service has eventual consistency and 3 seconds wasn't enough time for newly placed orders to become fetchable by IDTest plan
pytest tests/integration/test_portfolio.py::TestOrderMutations::test_get_order_by_id -vand verify it passes consistentlypytest tests/integration/ -vto confirm no regressions🤖 Generated with Claude Code