Show completion time as metrics on the dashboard#16
Conversation
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def metrics(): |
There was a problem hiding this comment.
Actually thats a good point. Given we now have better support for usign metrics.json maybe we need a toolkit helper to actually help make / populate it
There was a problem hiding this comment.
That could be nice! Right now, i only add metrics from the test file, but mainly because it would need a more complex util to update metrics safely from multiple processes. It would be great if the toolkit could help with that.
| import msgs | ||
|
|
||
|
|
||
| class StuckDetector: |
There was a problem hiding this comment.
Do you think this is relatively generic? (toolkit?)
There was a problem hiding this comment.
I was thinking about this, but probably every use-case is different enough so you cant use the same thing unless we make it complex with a lot of parameters. Might be better to have recepie-book or something with testing tricks like this.
Main changes:
metrics.jsonwith the completion time for each waypoint session. This would be useful to compare policies.https://app.artefacts.com/artefacts-demos/go2-demo/job/775eed02-0657-4836-9b96-efc81697f450