Apply updates for PHP 8.x

Dockerfile

@@ -1,4 +1,4 @@
-FROM php:7.4-fpm-alpine
+FROM php:8.2-fpm-alpine
 
 ENV FOP_HOME=/usr/share/fop-2.1 \
     COMPOSER_ALLOW_SUPERUSER=1 \
@@ -15,6 +15,7 @@ RUN set -xe \
       autoconf \
       build-base \
       openldap-dev \
+      linux-headers \
     && docker-php-ext-install \
       calendar \
       gettext \
@@ -28,10 +29,10 @@ RUN set -xe \
       zip \
       ldap \
     && pecl install apcu pcov \
-    && curl -Ls https://github.com/websupport-sk/pecl-memcache/archive/NON_BLOCKING_IO_php7.tar.gz | tar xz -C / \
-    && cd /pecl-memcache-NON_BLOCKING_IO_php7 \
+    && curl -Ls https://github.com/websupport-sk/pecl-memcache/archive/refs/tags/8.2.tar.gz | tar xz -C / \
+    && cd /pecl-memcache-8.2 \
     && phpize && ./configure && make && make install \
-    && cd / && rm -rf /pecl-memcache-NON_BLOCKING_IO_php7 \
+    && cd / && rm -rf /pecl-memcache-8.2 \
     && docker-php-ext-enable apcu memcache pcov \
     && apk add --no-cache --virtual .phpext-rundeps \
       gettext \

apps/qubit/modules/repository/actions/browseAction.class.php

@@ -211,7 +211,7 @@ private function getAdvancedFilterTerms()
     private function setI18nFieldCultures()
     {
         foreach (self::$AGGS as $key => &$value) {
-            if (false !== array_search('i18n.%s', $value['field'])) {
+            if (is_array($value['field']) && false !== array_search('i18n.%s', $value['field'])) {
                 $value['field'] = sprintf($value['field'], $this->context->user->getCulture());
             }
         }

lib/helper/QubitHelper.php

@@ -102,7 +102,7 @@ function render_b5_field($field, $translation = null, $options = [])
     $widget = $field->getWidget();
 
     if (
-        in_array($field->type, ['checkbox', 'radio'])
+        in_array($widget->getOption('type'), ['checkbox', 'radio'])
         || $widget instanceof sfWidgetFormSelectRadio
         || (
             $widget instanceof sfWidgetFormChoice
@@ -113,7 +113,7 @@ function render_b5_field($field, $translation = null, $options = [])
         $isFormCheck = true;
         $inputClass = 'form-check-input';
         $labelClass = 'form-check-label';
-    } elseif ('color' == $field->type) {
+    } elseif ('color' == $widget->getOption('type')) {
         $inputClass .= ' form-control-color';
     }
 
@@ -773,7 +773,7 @@ function render_autocomplete_string($hit)
     }
 
     if (0 < count($levelOfDescriptionAndIdentifier)) {
-        $string[] = implode($levelOfDescriptionAndIdentifier, ' ');
+        $string[] = implode(' ', $levelOfDescriptionAndIdentifier);
     }
 
     $titleAndPublicationStatus = [];
@@ -787,7 +787,7 @@ function render_autocomplete_string($hit)
     }
 
     if (0 < count($titleAndPublicationStatus)) {
-        $string[] = implode($titleAndPublicationStatus, ' ');
+        $string[] = implode(' ', $titleAndPublicationStatus);
     }
 
     return implode(' - ', $string);

lib/job/arGearman.class.php

@@ -98,7 +98,7 @@ public static function getAbilities($options = [])
                 $abilities = array_merge($abilities, $config['worker_types'][$type]);
             }
         } else {
-            $abilities = call_user_func_array('array_merge', $config['worker_types']);
+            $abilities = call_user_func_array('array_merge', array_values($config['worker_types']));
         }
 
         return $abilities;

lib/model/QubitActor.php

@@ -70,7 +70,7 @@ public function __get($name)
                 return [];
         }
 
-        return call_user_func_array([$this, 'BaseActor::__get'], $args);
+        return call_user_func_array('BaseActor::__get', $args);
     }
 
     public function __set($name, $value)
@@ -104,7 +104,7 @@ public function __set($name, $value)
                 return $this;
         }
 
-        return call_user_func_array([$this, 'BaseActor::__set'], $args);
+        return call_user_func_array('BaseActor::__set', $args);
     }
 
     public function save($connection = null)

lib/model/QubitInformationObject.php

@@ -123,7 +123,7 @@ public function __get($name)
             case 'sourceStandard':
                 foreach ($this->ancestors->andSelf()->orderBy('rgt') as $item) {
                     if (isset($item->sourceStandard)) {
-                        return call_user_func_array([$item, 'QubitObject::__get'], $args);
+                        return call_user_func_array('QubitObject::__get', $args);
                     }
 
                     // Stop iteration before the root object is reached
@@ -135,7 +135,7 @@ public function __get($name)
                 break;
 
             default:
-                return call_user_func_array([$this, 'BaseInformationObject::__get'], $args);
+                return call_user_func_array('BaseInformationObject::__get', $args);
         }
     }
 
@@ -172,7 +172,7 @@ public function __set($name, $value)
                 return $this;
 
             default:
-                return call_user_func_array([$this, 'BaseInformationObject::__set'], $args);
+                return call_user_func_array('BaseInformationObject::__set', $args);
         }
     }
 

lib/model/QubitObject.php

@@ -43,7 +43,7 @@ public function __isset($name)
                 return isset($this->values['slug']);
 
             default:
-                return call_user_func_array([$this, 'BaseObject::__isset'], $args);
+                return call_user_func_array('BaseObject::__isset', $args);
         }
     }
 
@@ -69,7 +69,7 @@ public function __get($name)
                 return $this->values['slug'];
 
             default:
-                return call_user_func_array([$this, 'BaseObject::__get'], $args);
+                return call_user_func_array('BaseObject::__get', $args);
         }
     }
 
@@ -84,7 +84,7 @@ public function __set($name, $value)
                 return $this;
 
             default:
-                return call_user_func_array([$this, 'BaseObject::__set'], $args);
+                return call_user_func_array('BaseObject::__set', $args);
         }
     }
 

lib/model/QubitRepository.php

@@ -53,7 +53,7 @@ public function __get($name)
                 break;
 
             default:
-                return call_user_func_array([$this, 'BaseRepository::__get'], $args);
+                return call_user_func_array('BaseRepository::__get', $args);
         }
     }
 
@@ -88,7 +88,7 @@ public function __set($name, $value)
                 return $this;
 
             default:
-                return call_user_func_array([$this, 'BaseRepository::__set'], $args);
+                return call_user_func_array('BaseRepository::__set', $args);
         }
     }
 

lib/model/QubitSlug.php

@@ -78,7 +78,7 @@ public static function slugify($slug, $creationType = null)
         $slugCreation = (null === $creationType) ? sfConfig::get('app_permissive_slug_creation', QubitSlug::SLUG_RESTRICTIVE) : $creationType;
 
         // Remove apostrophes from slug
-        $slug = preg_replace('/\'/', '', $slug);
+        $slug = preg_replace('/\'/', '', (string) $slug);
 
         switch ($slugCreation) {
             case QubitSlug::SLUG_PERMISSIVE:

lib/model/om/BaseActor.php

@@ -90,7 +90,7 @@ public function __isset($name)
 
     try
     {
-      return call_user_func_array(array($this, 'QubitObject::__isset'), $args);
+      return call_user_func_array('QubitObject::__isset', $args);
     }
     catch (sfException $e)
     {
@@ -149,7 +149,7 @@ public function __get($name)
 
     try
     {
-      return call_user_func_array(array($this, 'QubitObject::__get'), $args);
+      return call_user_func_array('QubitObject::__get', $args);
     }
     catch (sfException $e)
     {
@@ -242,7 +242,7 @@ public function __get($name)
 
     try
     {
-      if (1 > strlen($value = call_user_func_array(array($this->getCurrentactorI18n($options), '__get'), $args)) && !empty($options['cultureFallback']))
+      if (1 > strlen((string) $value = call_user_func_array(array($this->getCurrentactorI18n($options), '__get'), $args)) && !empty($options['cultureFallback']))
       {
         return call_user_func_array(array($this->getCurrentactorI18n(array('sourceCulture' => true) + $options), '__get'), $args);
       }
@@ -266,7 +266,7 @@ public function __set($name, $value)
       $options = $args[2];
     }
 
-    call_user_func_array(array($this, 'QubitObject::__set'), $args);
+    call_user_func_array('QubitObject::__set', $args);
 
     call_user_func_array(array($this->getCurrentactorI18n($options), '__set'), $args);
 
@@ -283,7 +283,7 @@ public function __unset($name)
       $options = $args[1];
     }
 
-    call_user_func_array(array($this, 'QubitObject::__unset'), $args);
+    call_user_func_array('QubitObject::__unset', $args);
 
     call_user_func_array(array($this->getCurrentactorI18n($options), '__unset'), $args);
 

lib/model/om/BaseActorI18n.php

@@ -209,6 +209,7 @@ public function __isset($name)
     throw new sfException("Unknown record property \"$name\" on \"".get_class($this).'"');
   }
 
+  #[\ReturnTypeWillChange]
   public function offsetExists($offset)
   {
     $args = func_get_args();
@@ -250,6 +251,7 @@ public function __get($name)
     throw new sfException("Unknown record property \"$name\" on \"".get_class($this).'"');
   }
 
+  #[\ReturnTypeWillChange]
   public function offsetGet($offset)
   {
     $args = func_get_args();
@@ -304,6 +306,7 @@ public function __set($name, $value)
     return $this;
   }
 
+  #[\ReturnTypeWillChange]
   public function offsetSet($offset, $value)
   {
     $args = func_get_args();
@@ -335,6 +338,7 @@ public function __unset($name)
     return $this;
   }
 
+  #[\ReturnTypeWillChange]
   public function offsetUnset($offset)
   {
     $args = func_get_args();

lib/model/om/BaseContactInformation.php

@@ -228,6 +228,7 @@ public function __isset($name)
     throw new sfException("Unknown record property \"$name\" on \"".get_class($this).'"');
   }
 
+  #[\ReturnTypeWillChange]
   public function offsetExists($offset)
   {
     $args = func_get_args();
@@ -299,6 +300,7 @@ public function __get($name)
     throw new sfException("Unknown record property \"$name\" on \"".get_class($this).'"');
   }
 
+  #[\ReturnTypeWillChange]
   public function offsetGet($offset)
   {
     $args = func_get_args();
@@ -355,6 +357,7 @@ public function __set($name, $value)
     return $this;
   }
 
+  #[\ReturnTypeWillChange]
   public function offsetSet($offset, $value)
   {
     $args = func_get_args();
@@ -396,6 +399,7 @@ public function __unset($name)
     return $this;
   }
 
+  #[\ReturnTypeWillChange]
   public function offsetUnset($offset)
   {
     $args = func_get_args();

lib/model/om/BaseInformationObject.php

@@ -119,7 +119,7 @@ public function __isset($name)
 
     try
     {
-      return call_user_func_array(array($this, 'QubitObject::__isset'), $args);
+      return call_user_func_array('QubitObject::__isset', $args);
     }
     catch (sfException $e)
     {
@@ -178,7 +178,7 @@ public function __get($name)
 
     try
     {
-      return call_user_func_array(array($this, 'QubitObject::__get'), $args);
+      return call_user_func_array('QubitObject::__get', $args);
     }
     catch (sfException $e)
     {
@@ -237,7 +237,7 @@ public function __get($name)
 
     try
     {
-      if (1 > strlen($value = call_user_func_array(array($this->getCurrentinformationObjectI18n($options), '__get'), $args)) && !empty($options['cultureFallback']))
+      if (1 > strlen((string) $value = call_user_func_array(array($this->getCurrentinformationObjectI18n($options), '__get'), $args)) && !empty($options['cultureFallback']))
       {
         return call_user_func_array(array($this->getCurrentinformationObjectI18n(array('sourceCulture' => true) + $options), '__get'), $args);
       }
@@ -301,7 +301,7 @@ public function __set($name, $value)
       $options = $args[2];
     }
 
-    call_user_func_array(array($this, 'QubitObject::__set'), $args);
+    call_user_func_array('QubitObject::__set', $args);
 
     call_user_func_array(array($this->getCurrentinformationObjectI18n($options), '__set'), $args);
 
@@ -318,7 +318,7 @@ public function __unset($name)
       $options = $args[1];
     }
 
-    call_user_func_array(array($this, 'QubitObject::__unset'), $args);
+    call_user_func_array('QubitObject::__unset', $args);
 
     call_user_func_array(array($this->getCurrentinformationObjectI18n($options), '__unset'), $args);
 

lib/model/om/BaseInformationObjectI18n.php

@@ -225,6 +225,7 @@ public function __isset($name)
     throw new sfException("Unknown record property \"$name\" on \"".get_class($this).'"');
   }
 
+  #[\ReturnTypeWillChange]
   public function offsetExists($offset)
   {
     $args = func_get_args();
@@ -266,6 +267,7 @@ public function __get($name)
     throw new sfException("Unknown record property \"$name\" on \"".get_class($this).'"');
   }
 
+  #[\ReturnTypeWillChange]
   public function offsetGet($offset)
   {
     $args = func_get_args();
@@ -320,6 +322,7 @@ public function __set($name, $value)
     return $this;
   }
 
+  #[\ReturnTypeWillChange]
   public function offsetSet($offset, $value)
   {
     $args = func_get_args();
@@ -351,6 +354,7 @@ public function __unset($name)
     return $this;
   }
 
+  #[\ReturnTypeWillChange]
   public function offsetUnset($offset)
   {
     $args = func_get_args();

lib/model/om/BaseNote.php

@@ -208,6 +208,7 @@ public function __isset($name)
     throw new sfException("Unknown record property \"$name\" on \"".get_class($this).'"');
   }
 
+  #[\ReturnTypeWillChange]
   public function offsetExists($offset)
   {
     $args = func_get_args();
@@ -279,6 +280,7 @@ public function __get($name)
     throw new sfException("Unknown record property \"$name\" on \"".get_class($this).'"');
   }
 
+  #[\ReturnTypeWillChange]
   public function offsetGet($offset)
   {
     $args = func_get_args();
@@ -335,6 +337,7 @@ public function __set($name, $value)
     return $this;
   }
 
+  #[\ReturnTypeWillChange]
   public function offsetSet($offset, $value)
   {
     $args = func_get_args();
@@ -376,6 +379,7 @@ public function __unset($name)
     return $this;
   }
 
+  #[\ReturnTypeWillChange]
   public function offsetUnset($offset)
   {
     $args = func_get_args();