Fix for slugs with international chars #1921

[miceno]

This PR solves issue #1921, by allowing a new configuration setting to use a different strategy to generate slugs, more suitable for international users.

It adds a new option on Global settings > Permalink, that allows replacing accented chars like á, é with ASCII chars a, e:

It uses the intl PHP module, and thus the PR includes some changes on building docker images.

The code autodetects the presence of the intl PHP module and for those setups that will not include it, the new option will not show.

Transliteration is done using the intl function transliterator_transliterate, that allows providing a mapping for the transliteration. The mapping is provided in a configuration setting with a default value.

The PR is against stable/2.8.x branch to allow other AtoM users to have it available as soon as it is merged.

[anvit]

Hi @miceno ! Thanks so much for reporting this issue and for submitting a PR. We're close to finalizing the 2.9 release so this change won't make it in the current release, but we'll be happy to review and accept this for the next release!

[anvit]

@miceno I did notice a couple small issues at a quick glance. I noticed that this branch is based off of the stable/2.8.x branch. Would you be able to rebase your changes to the qa/2.x branch, and update the PR to merge to that branch instead? That's the development branch with most up to date code and the stable/2.8.x is the release branch.

The other thing I noticed is that the tests were failing and were complaining about docker-compose not being found. This is likely due to the changes to the Dockerfile. Could you update that so that the intl dependencies are installed directly. My guess is that installing php-intl or the appropriate equivalent package instead of using docker-php-ext-install should resolve this.

[miceno]

I will have a look at it later, the change you proposed is not trivial for me, I don't know all the details about the docker configuration.

It is on the stable/2.8.x branch since I will appreciate it will show on the next release, and I thought next release was 2.8.3, not 2.9. I will try to change the base for the PR once I have moved forward with the docker changes.

[miceno]

Hi @anvit ,

I updated the PR to target qa/2.x branch. Let me know if there is anything else to deal with.

[sarah-mason]

Hi @miceno - thank you for rebasing your PR! I've run the tests and the PHP CS Fixer test failed. We have only just begun work with 2.10 and have some other work on at the moment as well, so there is no rush with your investigation (as I said on PR#1924). But don't hesitate to ask any questions!

Also, if you are interested in joining our maintainers at a monthly community development meeting, please send me an email at contributors@artefactual.com and I'll get you more information.