This repository has been archived by the owner on Jan 2, 2025. It is now read-only.
[#28] refactor to reduce code repetition #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaohoward
force-pushed
the
j_qaddr_ops
branch
from
42f6f2d to
ff15fed
Compare
gaohoward
force-pushed
the
j_qaddr_ops
branch
from
ff15fed to
fb26993
Compare
Msarawan
reviewed
Nov 27, 2024
|
Can you add more context to the PR and the commit please? |
gaohoward
force-pushed
the
j_qaddr_ops
branch
from
fb26993 to
a6381b6
Compare
Sure will do. Thanks! |
Currently in ArtemisJolokia code there are many common codes among fetching methods for different components. For example readBrokerAttributes, readAddressAttributes and readClusterConnectionAttributes are all sending 'POST' requests with similar pattern but only different parameters. It can be abstracted to a common method shared by those methods and also will be reused when we add new components like Bridges.
gaohoward
force-pushed
the
j_qaddr_ops
branch
from
a6381b6 to
8b46c90
Compare
lavocatt
approved these changes
Nov 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in ArtemisJolokia code there are many common codes among
fetching methods for different components. For example
readBrokerAttributes, readAddressAttributes and
readClusterConnectionAttributes are all sending 'POST' requests
with similar pattern but only different parameters.
It can be abstracted to a common method shared by those methods
and also will be reused when we add new components like Bridges.