-
Notifications
You must be signed in to change notification settings - Fork 16
[#240] move api server to its own repo #241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @lavocatt , on the Pods List page
and the Broker Details page
, clicking on both Edit broker
and Delete broker
buttons does not open the editors and the delete modal pages. Instead, the below error message is displayed.
I approved on my side leaving @Msarawan for the issues she found. |
This commit removes the code from the api-server. The new repository where the code lives now is https://github.com/artemiscloud/activemq-artemis-jolokia-api-server. The Dockerfile got synchronized back to the one from the console-plugin-template at commit 2b4dbe4b4313e258be1754815614cf7d47f45c11 The deploy/ folder content has been synchronized back to its state before introducing the api-server in the project. At commit fc70c0e. The only difference left is that the plugin relies on the activemq-artemis-jolokia-api-server proxy service to be there: ``` proxy: - type: Service alias: api-server-service endpoint: type: Service service: name: activemq-artemis-jolokia-api-server namespace: activemq-artemis-jolokia-api-server port: 9443 ``` Follow the updates in the Readme for more information about how to develop and deploy now. This work is linked to the PR that adds the jolokia-api-server code to its own repo there artemiscloud/activemq-artemis-jolokia-api-server#4
Thanks a lot for catching this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work Thomas.
This commit removes the code from the api-server. The new repository where the code lives now is
https://github.com/artemiscloud/activemq-artemis-jolokia-api-server.
The Dockerfile got synchronized back to the one from the console-plugin-template at commit 2b4dbe4b4313e258be1754815614cf7d47f45c11
The deploy/ folder content has been synchronized back to its state before introducing the api-server in the project. At commit fc70c0e.
The only difference left is that the plugin relies on the activemq-artemis-jolokia-api-server proxy service to be there:
Follow the updates in the Readme for more information about how to develop and deploy now.
This work is linked to the PR that adds the jolokia-api-server code to its own repo there
artemiscloud/activemq-artemis-jolokia-api-server#4