feat(DIA-1017): add bottom sheet to infinite discovery#11318
feat(DIA-1017): add bottom sheet to infinite discovery#11318araujobarret merged 1 commit intomainfrom
Conversation
| <> | ||
| <Spacer y={1} /> | ||
| <Biography artist={artist} /> | ||
| <Flex maxWidth={MAX_WIDTH_BIO} px={2}> |
There was a problem hiding this comment.
nothing changed so far, lifted up some elements to be able to share the Biography element easily
| artist: ArtistFollowButton_artist$key | ||
| } | ||
|
|
||
| export const ArtistFollowButton: FC<ArtistFollowButtonProps> = ({ artist }) => { |
There was a problem hiding this comment.
Separated the personalized data into an individual query.
| partner: PartnerFollowButton_partner$key | ||
| } | ||
|
|
||
| export const PartnerFollowButton: FC<PartnerFollowButtonProps> = ({ partner }) => { |
There was a problem hiding this comment.
Created a version of the follow button personalized and with an isolated query. Same as we do for ArtistFollows
| internalID: string | ||
| isFollowd: boolean | null | ||
| onCompleted?: (isFollowd: boolean) => void | ||
| isFollowed: boolean | null |
There was a problem hiding this comment.
fixed the typo, was even creating ambiguity on the store, if somewhere we updated the isFollowed within the updater it wouldn't reflect to the elements using this one because of the typo.
| * @reason moving away personalized data into different queries | ||
| */ | ||
| @track() | ||
| export class PartnerFollowButton extends React.Component<Props, State> { |
There was a problem hiding this comment.
We need to get rid of this Element at some point, deprecated it to avoid ppl using it
| name | ||
| } | ||
| partner { | ||
| partner(shallow: true) { |
There was a problem hiding this comment.
since I wanted to use shallow true in the new elements, the shared children started complaining about inconsistencies, so I had to replicate it which is a good improvement in general avoiding extra hits to partner and artist endpoint when the artwork already has all the data
| import { setupTestWrapper } from "app/utils/tests/setupTestWrapper" | ||
| import { graphql } from "react-relay" | ||
|
|
||
| describe("InfiniteDiscoveryBottomSheetFooter", () => { |
There was a problem hiding this comment.
This file decreases the morale of the TDD team, but was failing and I spent a few hours trying to identify why and couldn't figure it out.
araujobarret
force-pushed
the
araujobarret/dia-1017/bottom-sheet-infinite-discovery
branch
from
61d44aa to
e80af24
Compare
araujobarret
force-pushed
the
araujobarret/dia-1017/bottom-sheet-infinite-discovery
branch
from
e80af24 to
1abc528
Compare
araujobarret
deleted the
araujobarret/dia-1017/bottom-sheet-infinite-discovery
branch
2 participants
This PR resolves DIA-1017
Description
This PR adds the bottom sheet element to the infinite discovery screen. We use preloaded data from the artwork card screen have the data ready if the user wants to swipe to check more details.
For next PRs:
iOS
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-12-19.at.23.12.55.mp4
Android
Screen.Recording.2024-12-19.at.23.23.16.mov
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.