Fix common prefix calculation #170
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...by making commonPrefix variable nullable to detect the case that no commonPrefix is set (and not start finding a common prefix once no common prefix is found, which means the commonPrefix is an empty string)
Owner
|
is it a bugfix? can you please describe bug or add a test case reproducing the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by making commonPrefix variable nullable to detect the case that no commonPrefix is set.
Otherwise this would trigger finding a common prefix once no common prefix is found (in the old implementation that means the commonPrefix is an empty string which is just the result of finding out there is no common prefix).