Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme fixes #142

Merged
merged 2 commits into from
Dec 15, 2015
Merged

Readme fixes #142

merged 2 commits into from
Dec 15, 2015

Conversation

chscorpio
Copy link
Contributor

  • In docker-setup, I removed the "Create Docker Swarm Cluster" section as the token-based swarm-master we create there will conflict with the one we create in docker-swarm.
    Duplicate Create Docker Swarm Cluster  #135
    and
    Docker Swarm instructions #136
  • In docker-swarm, I provided a command and example output to explain how a master has both a swarm-agent and swarm-agent-master container and followed that example with an explicit step to connect to the swarm cluster.
  • In docker-swarm, I explicitly required that we connect to the Swarm cluster before verifying that Wildfly and Couchbase are running because we just finished listing the network interfaces on swarm-node-02.
  • In docker-swarm, I added a sentence to take note which nodes were running Wildfly and Couchbase as they will need to be replaced accordingly in subsequent commands.
    Wildfire running on swarm-master #125
    and
    Need to set correct machine to configure Couchbase/WildFly #139
  • Otherwise, I fixed typos and grammatical errors as I encountered them.

…n as the token-based swarm-master we create there will conflict with the one we create in docker-swarm. arun-gupta#135 and arun-gupta#136

- In docker-swarm, I provided a command and example output to explain how a master has both a swarm-agent and swarm-agent-master container and followed that example with an explicit step to connect to the swarm cluster.
- In docker-swarm, I explicitly required that we connect to the Swarm cluster before verifying that Wildfly and Couchbase are running because we just finished listing the network interfaces on swarm-node-02.
- In docker-swarm, I added a sentence to take note which nodes were running Wildfly and Couchbase as they will need to be replaced accordingly in subsequent commands. arun-gupta#125 and arun-gupta#139
- Otherwise, I fixed typos and grammatical errors as I encountered them.
arun-gupta added a commit that referenced this pull request Dec 15, 2015
@arun-gupta arun-gupta merged commit 7f8e7be into arun-gupta:master Dec 15, 2015
@arun-gupta
Copy link
Owner

Fixes part of #137 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants