Skip to content

adding config class#84

Merged
arun1729 merged 1 commit intomasterfrom
v3.7.5
Apr 10, 2026
Merged

adding config class#84
arun1729 merged 1 commit intomasterfrom
v3.7.5

Conversation

@arun1729
Copy link
Copy Markdown
Owner

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 95.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.41%. Comparing base (d5bbab6) to head (308a348).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
cog/config.py 95.74% 2 Missing ⚠️
cog/torque.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   87.37%   87.41%   +0.04%     
==========================================
  Files          13       13              
  Lines        2432     2480      +48     
==========================================
+ Hits         2125     2168      +43     
- Misses        307      312       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a CogConfig class to encapsulate configuration settings, effectively preventing the mutation of global state by providing isolated configuration instances for Cog and Graph objects. The version has been bumped to 3.7.5. Feedback focuses on improving the robustness of the configuration override validation to prevent accidental method overwriting and refactoring path construction methods to use cog_db_path() and f-strings for better maintainability and readability.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 94b3736dc1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@arun1729 arun1729 merged commit 8053703 into master Apr 10, 2026
6 checks passed
@arun1729 arun1729 deleted the v3.7.5 branch April 10, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant