Skip to content

Conversation

@lautarobock
Copy link

I need textSearch feature from google map places. but you dont have been implemented.
I've made a fork and make some changes.
This is the pull request. If you are interesting, please merge. Then I will remove my fork.

Thanks

@abhinavguptas
Copy link

@arunisrael any plans to merge this one ?

@lautarobock
Copy link
Author

+1

@abhinavguptas
Copy link

@lautarobock I realise you didnt provided any test cases, it might be the thing stopping the pull request to merge.

@lautarobock
Copy link
Author

Is true, sorry, I just review my code, add test and then will do another
pull-request.

thanks

On Fri, Aug 8, 2014 at 1:32 PM, Abhinav Gupta notifications@github.com
wrote:

@lautarobock https://github.com/lautarobock I realise you didnt
provided any test cases, it might be the thing stopping the pull request to
merge.


Reply to this email directly or view it on GitHub
#1 (comment)
.

Lautaro

Saludos amigo quiere verse tan feliz como yo.. ah, pero tiene el poder
dentro de usted ahora mismo!, asique úselo!, envíe un dolar a Pato Feliz,
Avenida Siempre Viva 72 Springfield, no tarde! la felicidad, la felicidad
eterna solo a un dolar de distancia!

@lautarobock
Copy link
Author

Hi, I've create and pushed unit test and merge it.
Would you like to merge my fork?

@joaomarceloods
Copy link

+1

Just got this version working on my project. This is a great addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants