Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use path/filepath instead of path #457

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use path/filepath instead of path #457

wants to merge 1 commit into from

Conversation

mattn
Copy link

@mattn mattn commented Oct 18, 2021

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

path/filepath should be used for this.

@mattn mattn mentioned this pull request Oct 18, 2021
Merged
@mattn
Copy link
Author

mattn commented Oct 19, 2021

When testing, path.Clean(path.Base("../../../Hello World!.txt")) does not return your expected on Windows. Also calling path.Clean is not required.

@sergeyglazyrindev
Copy link

sergeyglazyrindev commented Oct 19, 2021 •
edited
Loading

hey @mattn . Owner of this package disappeared. I forked it and ready to support it in future.
You can check it here: https://github.com/sergeyglazyrindev/govalidator , make pull request and I merge it and make new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattn @sergeyglazyrindev