Refactor CredentialRepository to interface #415
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to include just the service components of this package (excluding routers, controllers etc) however ran into an issue.
Our repository structure is a little different from the default in this package. It can't be overridden as the underlying
OptionsFactory
doesn't allow for this as it's explicitly typed preventing us from doing so:laravel-webauthn/src/Services/Webauthn/OptionsFactory.php
Lines 12 to 17 in 6aea042
And also doesn't the repository if it's not the required type:
laravel-webauthn/src/Services/Webauthn/OptionsFactory.php
Lines 37 to 39 in 6aea042
This PR creates an interface for CredentialRepository and then updates OptionsFactory to use the interface instead.